Huawei AC-Charger (Pylontech) BMS connection #767
Conversation
|
I did some testing of this PR. Running a test poses some difficulties as the BMS requested current drops quickly and voltage limits also kick in. Moving to review / merge phase |
|
Alright 💪 I am confused that you did chose not to use the method "needsCharging()" I implemented for you. Was that a misunderstanding or why did you chose to use a different method name? I find "getImmediateChargingRequest()" is very specific to the Pylontech battery stats, however, the functionality can be applied with other BMSs as well. Hence the more general name "needsCharging()". |
|
Hi Bernhard, I considered to use the method name that you had in your implementation. However the naming scheme in BatteryStats.h mostly uses the typical get.../set... for getters and setters. needsCharging does not. I implemented a few getters and thought it would be good to apply this convention. Since I anyhow had to change the name I went for something that I considered consistent with how the naming was used in other parts of the code. I agree that this aligns naming with Pylontech. But I considered this better for understanding and code readability. That being said: I'm not so hung up on the actual name. But I think it should start with get.... I.e. the method should at least be called getNeedsCharging(). Let me know if I should change this Malte |
Same here. It seems this needs some work rebasing due to changes to the locales, which I will take care of. I will also clean up the remnants of "needsCharging()". I will not be able to test this due to lack of respective hardware. |
This change logically connects the AC-Charger with the BMS to add BMS initiated emergency charging and respecting BMS current limits.
schlimmchen
force-pushed
the
huawei_emergency_charge_support
branch
from
574e3ef to
6958119
Compare
|
Rebased onto current helgeerbe/development, solved conflicts, cleaned up "needsCharging()". |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
This PR connects the Huawei AC-Charger with the Battery BMS. It specifically introduces the following features:
When the BMS issues an charge immediate request and the charger is in internal automatic control mode then charging is started with full configured power. This behavior enabled / disabled on the GUI
The Huawei charger will respect BMS current limits now when charging and limit the current taking the BMS limit and an estimate of other DC sources into account.
I did some testing but would like to monitor this a bit over the course of the coming days. Marking this PR as draft for now.
The request is in #723